Feature: Coordinator #55

YukiTsuchida · 2026-01-16T08:19:15Z

Implementation of all coordinator features(only Simple Commit Protocol).

…logic

… field handling

…uality

…ignMethod enum

feat: IInitiator

feat: IAuthenticator

…oordinator interface

…Coordinator interface

feat: ICoordinator

…ent in core modules

… and TxManager

…rieval in TxManager

… transaction management

…tion

… consistency and clarity

…quiredAccounts

…ogic

… scope

…ontract

…rameter

…act state structure

…nt variable declarations

… abort

…add tests

…ion functions

…_PROTOCOL_SIMPLE

Improve gas coord state compact

github-actions · 2026-01-16T08:20:35Z

⛽ Gas Usage Changes

Comparison against main branch:

Click to view gas diff

Overall gas change: 0 (NaN%)

Calculated by Foundry Gas Snapshot Action

github-actions · 2026-01-16T08:21:32Z

LCOV of commit `e7581b1` during Coverage Report #275

Summary coverage rate:
  lines......: 96.5% (614 of 636 lines)
  functions..: 95.5% (106 of 111 functions)
  branches...: no data found

Files changed coverage rate:
                                         |Lines       |Functions  |Branches    
  Filename                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================
  src/core/Authenticator.sol             |14.3%     35| 0.0%     5|    -      0
  src/core/ContractModuleBase.sol        |83.3%      6| 0.0%     2|    -      0
  src/core/Coordinator.sol               |11.8%     17| 0.0%     2|    -      0
  src/core/CrossModule.sol               |36.7%     30| 0.0%    11|    -      0
  src/core/CrossSimpleModule.sol         |33.3%      3| 0.0%     1|    -      0
  src/core/CrossStore.sol                |17.1%     41| 0.0%     7|    -      0
  src/core/DelegatedLogicHandler.sol     |32.4%     68| 0.0%    22|    -      0
  src/core/IBCKeeper.sol                 |50.0%      4| 0.0%     2|    -      0
  src/core/Initiator.sol                 |10.5%     38| 0.0%     4|    -      0
  src/core/SimpleContractRegistry.sol    |25.0%      8| 0.0%     2|    -      0
  src/core/TxAtomicSimple.sol            | 4.9%    182| 0.0%     9|    -      0
  src/core/TxAuthManager.sol             |17.1%     82| 0.0%    14|    -      0
  src/core/TxIDUtils.sol                 |50.0%      2| 0.0%     1|    -      0
  src/core/TxManager.sol                 |31.1%     45| 0.0%    14|    -      0
  src/example/ERC20TransferModule.sol    |21.2%     33| 0.0%     7|    -      0
  src/example/MockCrossContract.sol      |40.0%     10| 0.0%     2|    -      0
  src/example/SampleExtensionVerifier.sol|10.0%     10| 0.0%     1|    -      0

Full coverage report

mattsu6666

Thank you for your hard work! LGTM👍

YukiTsuchida and others added 30 commits November 5, 2025 09:29

feat: definition IInitiator

67093af

refactor: update contract transaction structure and related decoding …

5732fae

…logic

feat: IAuthenticator

f323f24

refactor: remove redundant comments from Auth.proto for clarity

f2fc4c3

refactor: remove outdated comments from MsgSignTx for clarity

d0d2f79

Refactor MsgIBCSignTx library to MsgExtSignTx with updated struct and…

f1c7a4c

… field handling

refactor: remove IBC signing references from IAuthenticator interface

fd752a0

feat: ICoordinator

9e71b20

fix: update lint-staged configuration to use npm for Solidity formatting

f784749

fix: update lint:sol script to enforce no warnings and improve code q…

cc98902

…uality

Merge branch 'def-interface-initiator' into def-interface-authenticator

cf6d29e

refactor: update TxSigned event to use AuthType.AuthMode and remove S…

30ff557

…ignMethod enum

Merge pull request #17 from datachainlab/def-interface-initiator

3c2fb43

feat: IInitiator

Merge pull request #18 from datachainlab/def-interface-authenticator

8ea082a

feat: IAuthenticator

Merge branch 'feature/coordinator' into def-interface-coordinator

34e4f72

refactor: remove inheritance from IInitiator and IAuthenticator in IC…

7c2f67f

…oordinator interface

refactor: remove unused imports of IInitiator and IAuthenticator in I…

e4eac14

…Coordinator interface

Merge pull request #19 from datachainlab/def-interface-coordinator

5ac4183

feat: ICoordinator

impl-initiator

d9c283d

refactor: simplify constructor parameters and improve storage managem…

7884e54

…ent in core modules

refactor: clean up comments and improve code readability in CoreStore…

f7cb80e

… and TxManager

refactor: improve error handling and streamline coordinator state ret…

84388bf

…rieval in TxManager

fix: solhint

cf15314

refactor: rename hasTx to isTxRecorded for clarity and consistency in…

6dfcdfb

… transaction management

fix: optimize loop logic for checking existing keys in account collec…

09e0275

…tion

refactor: rename _collectRequiredAccounts to _getRequiredAccounts for…

de38af0

… consistency and clarity

fix: remove unnecessary inline assembly for trimming output in _getRe…

d4abb8b

…quiredAccounts

fix bugs

bbea7c7

feat: add TxRunner and TxRunnerBase contracts for transaction management

da8cc0a

refactor: update _runTx to include a ToDo for transaction execution l…

7890f97

…ogic

YukiTsuchida and others added 22 commits January 6, 2026 13:43

refactor: improve error handling and variable scope in _runTx function

9b9ad84

refactor: move dummy packet initialization for getModule into a block…

af1127a

… scope

refactor: enhance transaction management and testing in Coordinator c…

49b108c

…ontract

refactor: update TxInitiated event to include MsgInitiateTx data

432ba85

feat: Update Txmanager contract ABI and methods for transaction handling

6620000

refactor: update runTxIfCompleted method to include transaction ID pa…

7739c8f

…rameter

refactor: remove unused parameter from runTxIfCompleted function

7e81b0b

refactor: streamline coordinator state management by introducing comp…

e134954

…act state structure

test: CrossStore.sol

fc38bb3

refactor: simplify _loadCoordinatorState function by removing redunda…

4aa872e

…nt variable declarations

refactor: lower minimum coverage requirement from 97 to 96

51af452

feat: add TxAuthCompleted event emission in Authenticator contract

a266604

refactor: optimize gas usage by cleaning up txCoordSigners storage on…

2a03e4a

… abort

feat: implement TxIdUtils library for transaction ID computation and …

60055ec

…add tests

refactor: rename TxIdUtils to TxIDUtils for consistency

1333d5b

Merge pull request #51 from datachainlab/delete-txMsg

140262a

chore(gas): update .gas-snapshot [skip ci]

d69c643

Merge branch 'develop' into improve-gas-CoordStateCompact2

fe25d6b

refactor: remove unused participant confirmation and protocol complet…

469776d

…ion functions

refactor: optimize loop increment in _runSimpleProtocol function

172cdee

comment: add CoordStateCompact struct for optimized storage in COMMIT…

8c538ed

…_PROTOCOL_SIMPLE

Merge pull request #54 from datachainlab/improve-gas-CoordStateCompact2

e7581b1

Improve gas coord state compact

YukiTsuchida requested a review from mattsu6666 January 16, 2026 08:20

chore(gas): update .gas-snapshot [skip ci]

61c581a

YukiTsuchida self-assigned this Jan 16, 2026

YukiTsuchida marked this pull request as ready for review January 16, 2026 08:22

mattsu6666 approved these changes Jan 16, 2026

View reviewed changes

YukiTsuchida merged commit db5fc94 into main Jan 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Coordinator #55

Feature: Coordinator #55

Uh oh!

YukiTsuchida commented Jan 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

mattsu6666 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Feature: Coordinator #55

Feature: Coordinator #55

Uh oh!

Conversation

YukiTsuchida commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2026

⛽ Gas Usage Changes

Uh oh!

github-actions bot commented Jan 16, 2026

LCOV of commit e7581b1 during Coverage Report #275

Uh oh!

mattsu6666 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YukiTsuchida commented Jan 16, 2026 •

edited

Loading

LCOV of commit `e7581b1` during Coverage Report #275